Attempt to fix hiding of attribute described in markdown. #139
Conversation
✅ Deploy Preview for super-tapioca-5987ce ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
Well the preview indicates that using entities was definitely not the correct fix here. Not sure what is. |
|
Removing the quotes was the only fix I could find. Updating unified to a more recent version might also fix the problem but I'm not in a position to test that easily. |
|
Huh, that's interesting behavior. Not sure if you tried this, but would using an HTML entity work here? for these components by adding the `data-gwd-opt="e;static"e;` attribute
Yeah, they are definitely a bit outdated. I think we would like to move markdown to its own standalone plugin (in the event someone doesn't want to use unified, and so that would be a good time to give these all full upgrade - ProjectEvergreen/greenwood#1247) edit: sorry, just your comment (#139 (comment)). Let me try and take look |
thescientist13
added
bug
|
Hmm, interestingly it seems to display fine when just running the dev server 🤔 What's even more interesting is that there's another similar case here but it renders fine? |
|
So, with some more testing, if I use single quotes, it seems fine (might be the short term solution for now) Or removing the hyphens
Let me test now with bumping all the dependencies and or mixing / matching, to see if it's coming from somewhere down in the stack. |
|
Just fyi, I think the entity is |
|
Ah, thanks @brettle . That one still seems to lead to the same outcome. I tried upgrading all the related markdown deps and even commented out our custom markdown plugins and it still disappears. Even if I use a code fence block instead of inline one 😕 ```html
data-gwd-opt="static"
```
So I think this is something a little more involved, maybe on the Greenwood side. I think let's go with single quotes for now since that seems to work at least, and let me track this on the Greenwood side. |
| @@ -37,7 +37,7 @@ Now if we look in the HTML output for any of our pages, we will see pre-rendered | |||
| </app-footer> | |||
| ``` | |||
|
|
|||
| We can go one step further and instruct Greenwood to strip out the `<script>` tags for these components by adding the `data-gwd-opt="static"` attribute to them, since we have no need for any interactivity on these components. | |||
| We can go one step further and instruct Greenwood to strip out the `<script>` tags for these components by adding the `data-gwd-opt=static` attribute to them, since we have no need for any interactivity on these components. | |||
There was a problem hiding this comment.
it seems like single quotes works at least, so we can just roll with that for now
There was a problem hiding this comment.
Thank you so much for going down the rabbit hole on this one. 🐰
Opened an issue to track this on the Greenwood side and hopefully figure out what is going on here 😵
Summary of Changes